feat(config): generate types from config json schema #6053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6053 +/- ##
=======================================
Coverage 95.16% 95.16%
=======================================
Files 316 316
Lines 9207 9207
Branches 2075 2075
=======================================
Hits 8762 8762
Misses 445 445 🚀 New features to boost your workflow:
|
cjihrig
reviewed
Oct 28, 2025
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
Sorry if this review is premature since the PR is still in draft.
used claude to help with this. there's a good chance there's still extra fluff that needs sorting through. also still need to sort out the weird union behavior. we may need to maintain a fork with the fixes if they dont get merged upstream.
Member
Author
|
@cjihrig thanks for the early feedback! I've made adjustments based on your comments so far. |
* types are in a new file upstream. * still looking at how to reduce redundancy in intersection types generated by json2ts, for now fix in post-processing step. * temp todo for incorrect casing on otel type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Add generation script that generates types based on the otel config schema, using a tool called json-schema-to-typescript. These types are intended to be used in the configuration package instead of us handrolling the types.
TODO:
Type of change
How Has This Been Tested?